Enable to run all specs in DevContainer#27
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables running all test specs in DevContainer by replacing the external thrust-pcsat-wrapper dependency with a local shell script. Previously, the wrapper script was created inline during CI setup; now it's a committed file in the repository.
Changes:
- Added
tests/thrust-pcsat-wrapperscript that wraps the COAR Docker image for CHC solving - Updated test files to reference the local script path instead of expecting it in PATH
- Simplified CI workflow by removing inline script creation
- Added docker-in-docker support to DevContainer for running the wrapper script
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/thrust-pcsat-wrapper | New wrapper script for running COAR solver via Docker (replaces inline CI script) |
| tests/ui/pass/annot_exists.rs | Updated THRUST_SOLVER path to reference local script |
| tests/ui/fail/annot_exists.rs | Updated THRUST_SOLVER path to reference local script |
| .github/workflows/ci.yml | Removed inline script setup, now uses committed script file |
| .devcontainer/devcontainer.json | Added docker-in-docker feature to enable wrapper script execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coord-e
force-pushed
the
coord-e/include-pcsat-in-devcontainer
branch
from
f1f0a53 to
59f4cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some specs required thrust-pcsat-wrapper, I've replaced it with a local script located under tests/